Re: [PATCH 6/8] perf data: Switch to multiple cpu stream files

[Namhyung Kim]

On Thu, Dec 4, 2014 at 1:24 AM, Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
> +static int setup_streams(struct ctf_writer *cw, struct perf_session *session)
> +{
> +       struct ctf_stream **stream;
> +       struct perf_header *ph = &session->header;
> +       int ncpus;
> +
> +       /*
> +        * Try to get the number of cpus used in the data file,
> +        * if not present fallback to the MAX_CPUS.
> +        */
> +       if (!ph)

I think this check is meaningless since perf_header struct is embedded
in perf_session so it shouldn't be NULL when refered from a session..

Thanks,
Namhyung


> +               ncpus = MAX_CPUS;
> +       else
> +               ncpus = ph->env.nr_cpus_avail;
> +
> +       stream = zalloc(sizeof(*stream) * ncpus);
> +       if (!stream) {
> +               pr_err("Failed to allocate streams.\n");
> +               return -ENOMEM;
> +       }
> +
> +       cw->stream     = stream;
> +       cw->stream_cnt = ncpus;
> +       return 0;
> +}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/