Re: [PATCH 6/8] perf data: Switch to multiple cpu stream files

[Jiri Olsa]

On Mon, Dec 08, 2014 at 05:17:44PM +0900, Namhyung Kim wrote:
> On Thu, Dec 4, 2014 at 1:24 AM, Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
> > +static int setup_streams(struct ctf_writer *cw, struct perf_session *session)
> > +{
> > +       struct ctf_stream **stream;
> > +       struct perf_header *ph = &session->header;
> > +       int ncpus;
> > +
> > +       /*
> > +        * Try to get the number of cpus used in the data file,
> > +        * if not present fallback to the MAX_CPUS.
> > +        */
> > +       if (!ph)
> 
> I think this check is meaningless since perf_header struct is embedded
> in perf_session so it shouldn't be NULL when refered from a session..

right, it's actually different in the git, I used:

        if (!ph || !ph->env.nr_cpus_avail)
                ncpus = MAX_CPUS;

I attached slightyl older version in email :-\

anyway, I'll send v2 shortly 

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/