Re: [PATCH 4/13] incorrect use of init_completion fixup

[Dmitry Torokhov]

On Fri, Dec 26, 2014 at 09:06:10AM +0100, Nicholas Mc Guire wrote:
> The successive init_completion calls should be reinit_completion calls.
> 
> patch against 3.19.0-rc1 linux-next
> 
> Acked-by: Helge Deller <deller@xxxxxx>
> Signed-off-by: Nicholas Mc Guire <der.herr@xxxxxxx>

Applied, thank you.

> ---
>  drivers/input/keyboard/hil_kbd.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/input/keyboard/hil_kbd.c b/drivers/input/keyboard/hil_kbd.c
> index 610a8af..5b152f2 100644
> --- a/drivers/input/keyboard/hil_kbd.c
> +++ b/drivers/input/keyboard/hil_kbd.c
> @@ -473,7 +473,7 @@ static int hil_dev_connect(struct serio *serio, struct serio_driver *drv)
>  	if (error)
>  		goto bail1;
> 
> -	init_completion(&dev->cmd_done);
> +	reinit_completion(&dev->cmd_done);
>  	serio_write(serio, 0);
>  	serio_write(serio, 0);
>  	serio_write(serio, HIL_PKT_CMD >> 8);
> @@ -482,7 +482,7 @@ static int hil_dev_connect(struct serio *serio, struct serio_driver *drv)
>  	if (error)
>  		goto bail1;
> 
> -	init_completion(&dev->cmd_done);
> +	reinit_completion(&dev->cmd_done);
>  	serio_write(serio, 0);
>  	serio_write(serio, 0);
>  	serio_write(serio, HIL_PKT_CMD >> 8);
> @@ -491,7 +491,7 @@ static int hil_dev_connect(struct serio *serio, struct serio_driver *drv)
>  	if (error)
>  		goto bail1;
> 
> -	init_completion(&dev->cmd_done);
> +	reinit_completion(&dev->cmd_done);
>  	serio_write(serio, 0);
>  	serio_write(serio, 0);
>  	serio_write(serio, HIL_PKT_CMD >> 8);
> --
> 1.7.10.4
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/