Re: [PATCH] Documentation: gpio: fix bindings document

[Rob Herring]

On Thu, Jan 15, 2015 at 2:52 AM, Masahiro Yamada
<yamada.m@xxxxxxxxxxxxxxxx> wrote:
> Signed-off-by: Masahiro Yamada <yamada.m@xxxxxxxxxxxxxxxx>

Perhaps some explanation. You can't just remove properties. Please
explain to what extent the old/wrong name is used. This patch is only
okay if there are no users of gpio-phandle.

Rob

> ---
>
>  Documentation/devicetree/bindings/gpio/gpio.txt | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio.txt b/Documentation/devicetree/bindings/gpio/gpio.txt
> index b9bd1d6..f7a158d 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio.txt
> +++ b/Documentation/devicetree/bindings/gpio/gpio.txt
> @@ -69,7 +69,8 @@ GPIO pin number, and GPIO flags as accepted by the "qe_pio_e" gpio-controller.
>  ----------------------------------
>
>  A gpio-specifier should contain a flag indicating the GPIO polarity; active-
> -high or active-low. If it does, the follow best practices should be followed:
> +high or active-low. If it does, the following best practices should be
> +followed:
>
>  The gpio-specifier's polarity flag should represent the physical level at the
>  GPIO controller that achieves (or represents, for inputs) a logically asserted
> @@ -147,7 +148,7 @@ contains information structures as follows:
>         numeric-gpio-range ::=
>                         <pinctrl-phandle> <gpio-base> <pinctrl-base> <count>
>         named-gpio-range ::= <pinctrl-phandle> <gpio-base> '<0 0>'
> -       gpio-phandle : phandle to pin controller node.
> +       pinctrl-phandle : phandle to pin controller node
>         gpio-base : Base GPIO ID in the GPIO controller
>         pinctrl-base : Base pinctrl pin ID in the pin controller
>         count : The number of GPIOs/pins in this range
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/