Re: [PATCH] fs: jffs2: Remove utf8 from printk string

From: David Woodhouse
Date: Fri Feb 06 2015 - 09:28:02 EST


On Fri, 2015-02-06 at 15:19 +0100, Rasmus Villemoes wrote:
> Any non-ascii characters are escaped before being show to user-space,
> so this shows up as
>
> jffs2: version 2.2. (NAND) \xffffffc2\xffffffa9\xffffffa9 2001-2006
> Red Hat, Inc.
>
> (I have no idea why the second byte is repeated.) Replace with a
> widely used ascii replacement.

Nah. Fix the bug, don't apply a crappy workaround. This is the 21st
century.

> Actually, I don't see the value in printing a copyright notice to the
> kernel log, especially since it's out-of-sync with the one at the top
> of the file.

Agreed. Removing it would be better than the crappy workaround. But
let's use it as a test case to fix the *real* bug first.

--
dwmw2

Attachment: smime.p7s
Description: S/MIME cryptographic signature