[PATCH 3.2 148/152] vfs: Fix vfsmount_lock imbalance in path_init()

From: Ben Hutchings
Date: Mon Feb 16 2015 - 21:58:05 EST

3.2.67-rc1 review patch. If anyone has any objections, please let me know.


From: Ben Hutchings <ben@xxxxxxxxxxxxxxx>

When backporting commit 4023bfc9f351 ("be careful with nd->inode in
path_init() and follow_dotdot_rcu()"), I failed to account for the
vfsmount_lock that is used in 3.2 but not upstream. path_init() takes
the lock if performing RCU lookup, but must drop it if (and only if)
it subsequently fails.

Reported-by: nuxi@xxxxxxxxxxx
References: https://bugzilla.kernel.org/show_bug.cgi?id=92531
Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
Tested-by: nuxi@xxxxxxxxxxx
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -1567,6 +1567,7 @@ static int path_init(int dfd, const char
if (!(nd->flags & LOOKUP_ROOT))
nd->root.mnt = NULL;
+ br_read_unlock(vfsmount_lock);
return -ECHILD;


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/