Re: [PATCH] MAINTAINERS: fix UTF-8 encoding

[Nicolas Iooss]

On 03/04/2015 11:21 PM, Geert Uytterhoeven wrote:
> On Wed, Mar 4, 2015 at 4:02 PM, Jiri Kosina <jkosina@xxxxxxx> wrote:
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -725,7 +725,7 @@ F:        staging/iio/trigger/iio-trig-bfin-timer.c
>>>
>>>  ANDROID DRIVERS
>>>  M:   Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>>> -M:   Arve Hj?nnev?g <arve@xxxxxxxxxxx>
>>> +M:   Arve Hj??nnev??g <arve@xxxxxxxxxxx>
>>
>> I don't really call that an improvement.
>>
>> The patch was sent as
>>
>>         Content-Type: text/plain; charset=y
>>
>> 'charset=y' (a) doesn't make any sense whatsoever (b) directly contradicts
>> the intent of the patch.
> 
> Just another case of user answering all git questions with "y".
> Been there, done that. Will be handled in git soon
> http://www.spinics.net/lists/git/msg246024.html
> 

Thanks for telling me what I did wrong.  I confirm I did what you
described, I still have the terminal open with the 2 questions git asked me:

$ git send-email --to trivial@xxxxxxxxxx --cc
linux-kernel@xxxxxxxxxxxxxxx 0001-MAINTAINERS-fix-UTF-8-encoding.patch
0001-MAINTAINERS-fix-UTF-8-encoding.patch
The following files are 8bit, but do not declare a
Content-Transfer-Encoding.
    0001-MAINTAINERS-fix-UTF-8-encoding.patch
Which 8bit encoding should I declare [UTF-8]? y
(mbox) Adding cc: Nicolas Iooss <nicolas.iooss_linux@xxxxxxx> from line
'From: Nicolas Iooss <nicolas.iooss_linux@xxxxxxx>'
(body) Adding cc: Nicolas Iooss <nicolas.iooss_linux@xxxxxxx> from line
'Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@xxxxxxx>'

From: Nicolas Iooss <nicolas.iooss_linux@xxxxxxx>
To: trivial@xxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx,
	Nicolas Iooss <nicolas.iooss_linux@xxxxxxx>
Subject: [PATCH] MAINTAINERS: fix UTF-8 encoding
Date: Wed,  4 Mar 2015 22:38:47 +0800
Message-Id: <1425479927-6769-1-git-send-email-nicolas.iooss_linux@xxxxxxx>
X-Mailer: git-send-email 2.3.1
MIME-Version: 1.0
Content-Type: text/plain; charset=y
Content-Transfer-Encoding: 8bit

Send this email? ([y]es|[n]o|[q]uit|[a]ll): y


It is quite misleading to have both a "non-y" and a "yes/no" answer.
Now that I know this, I will try not to do the same error the next times
I send patches with both UTF-8 and iso-8859-15 characters.

Should I send the patch again with proper encoding?

Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/