Re: [PATCH 4.0-rc1 v17 4/6] printk: Simple implementation for NMI backtracing

[Steven Rostedt]

On Wed, 04 Mar 2015 08:13:21 -0800
Joe Perches <joe@xxxxxxxxxxx> wrote:

> On Wed, 2015-03-04 at 10:12 +0000, Daniel Thompson wrote:
> > Currently there is a quite a pile of code sitting in
> > arch/x86/kernel/apic/hw_nmi.c to support safe all-cpu backtracing from NMI.
> > The code is inaccessible to backtrace implementations for other
> > architectures, which is a shame because they would probably like to be
> > safe too.
> > 
> > Copy this code into printk. We'll port the x86 NMI backtrace to it in a
> > later patch.
> 
> I think this would be better as a separate file
> rather than increasing the bulk of printk.c
> 

I agree, as printk already has its own directory. Perhaps a
"nmi_backtrace.c"?

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/