Re: [PATCH v2 1/1] thermal: intel Quark SoC X1000 DTS thermal driver

[Andy Shevchenko]

On Tue, Mar 3, 2015 at 3:13 AM, Ong, Boon Leong
<boon.leong.ong@xxxxxxxxx> wrote:
>>> +config INTEL_QUARK_DTS_THERMAL
>>> +    tristate "Intel Quark DTS thermal driver"
>>> +    depends on X86 && IOSF_MBI
>>
>>Since the change is in RC-1 suggest
>>depends on X86_INTEL_QUARK
>>you can skip this though it's not important.
> Ya. That is true now since the below commit has been merged:
> 8bbc2a135b63bee6b41fa90f415521a97995a49f to mainline in 4.0-rc1
>
> On another thought, how about adding INTEL_QUARK_DTS_THERMAL to
> be selected by X86_INTEL_QUARK  in arch/x86/Kconfig ... and we can
> drop the above dependencies from here.

This driver as far as I understand is not critical to run Intel Quark.
So, there is should not be a dependency in the platform definition.

On the other hand is the driver will work exclusively on Quark? If so,
better to leave the mentioned dependency, .i.e.
depends on X86_INTEL_QUARK

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/