RE: [PATCH v2 1/1] thermal: intel Quark SoC X1000 DTS thermal driver

From: Ong, Boon Leong
Date: Thu Mar 05 2015 - 11:20:12 EST

>-----Original Message-----
>From: Andy Shevchenko [mailto:andy.shevchenko@xxxxxxxxx]
>Sent: Friday, March 6, 2015 12:11 AM
>To: Ong, Boon Leong
>Cc: Bryan O'Donoghue; Zhang, Rui; edubezval@xxxxxxxxx; Kweh, Hock Leong;
>linux-pm@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
>Subject: Re: [PATCH v2 1/1] thermal: intel Quark SoC X1000 DTS thermal driver
>On Tue, Mar 3, 2015 at 3:13 AM, Ong, Boon Leong
><> wrote:
>>>> + tristate "Intel Quark DTS thermal driver"
>>>> + depends on X86 && IOSF_MBI
>>>Since the change is in RC-1 suggest
>>>depends on X86_INTEL_QUARK
>>>you can skip this though it's not important.
>> Ya. That is true now since the below commit has been merged:
>> 8bbc2a135b63bee6b41fa90f415521a97995a49f to mainline in 4.0-rc1
>> On another thought, how about adding INTEL_QUARK_DTS_THERMAL to
>> be selected by X86_INTEL_QUARK in arch/x86/Kconfig ... and we can
>> drop the above dependencies from here.
>This driver as far as I understand is not critical to run Intel Quark.
>So, there is should not be a dependency in the platform definition.
Yup, Quark platform can boot up without this driver selected by default.

>On the other hand is the driver will work exclusively on Quark? If so,
>better to leave the mentioned dependency, .i.e.
>depends on X86_INTEL_QUARK
Yup. Currently, it is exclusive to Quark.
In v3, I make it depends on X86_INTEL_QUARK only.