Re: [PATCH] printk: Use symbolic defines for console loglevels instead of numbers

[Alexander Kuleshov]

Hello Geert,

Yes, i thougt about this issue. I looked in git history and found the
commit - a8fe19ebfbfd90ec17c02284717238b02efb9580 where level 8
changed on 10,
so i decided to put CONSOLE_LOGLEVEL_DEBUG here.


2015-03-16 15:20 GMT+06:00 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>:
> On Mon, Mar 16, 2015 at 10:01 AM, Alexander Kuleshov
> <kuleshovmail@xxxxxxxxx> wrote:
>> --- a/arch/m68k/mac/macints.c
>> +++ b/arch/m68k/mac/macints.c
>> @@ -315,7 +315,7 @@ irqreturn_t mac_nmi_handler(int irq, void *dev_id)
>>         while (nmi_hold == 1)
>>                 udelay(1000);
>>
>> -       if (console_loglevel >= 8) {
>> +       if (console_loglevel >= CONSOLE_LOGLEVEL_DEBUG) {
>
> CONSOLE_LOGLEVEL_DEBUG == 10, not 8
>
> As there's no define for 8, perhaps you can use:
>
> "if (console_loglevel > CONSOLE_LOGLEVEL_DEFAULT) {"
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/