Re: [PATCH] printk: Use symbolic defines for console loglevels instead of numbers

[Geert Uytterhoeven]

Hi Alexander,

On Mon, Mar 16, 2015 at 11:50 AM, Alexander Kuleshov
<kuleshovmail@xxxxxxxxx> wrote:
> Yes, i thougt about this issue. I looked in git history and found the
> commit - a8fe19ebfbfd90ec17c02284717238b02efb9580 where level 8
> changed on 10,
> so i decided to put CONSOLE_LOGLEVEL_DEBUG here.

Thanks, that makes sense. Please add this valuable information to the patch
description, and you can add my

Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

for the m68k part.

> 2015-03-16 15:20 GMT+06:00 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>:
>> On Mon, Mar 16, 2015 at 10:01 AM, Alexander Kuleshov
>> <kuleshovmail@xxxxxxxxx> wrote:
>>> --- a/arch/m68k/mac/macints.c
>>> +++ b/arch/m68k/mac/macints.c
>>> @@ -315,7 +315,7 @@ irqreturn_t mac_nmi_handler(int irq, void *dev_id)
>>>         while (nmi_hold == 1)
>>>                 udelay(1000);
>>>
>>> -       if (console_loglevel >= 8) {
>>> +       if (console_loglevel >= CONSOLE_LOGLEVEL_DEBUG) {
>>
>> CONSOLE_LOGLEVEL_DEBUG == 10, not 8
>>
>> As there's no define for 8, perhaps you can use:
>>
>> "if (console_loglevel > CONSOLE_LOGLEVEL_DEFAULT) {"

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/