Re: crypto: img-hash - undefined Kconfig symbols

[James Hartley]

Hi Valentin,


> On 18 Mar 2015, at 01:35, Valentin Rothberg <valentinrothberg@xxxxxxxxx> wrote:
> 
> Hi James,
> 
> your commit d358f1abbf71 ("crypto: img-hash - Add Imagination
> Technologies hw hash accelerator") adds two selects on undefined
> Kconfig symbols, namely CRYPTO_ALG_API and CRYPTO_SHA224.
> 
> The first symbols looks like a typo since there is an option
> CRYPTO_ALGAPI defined in crypto/Kconfig.  

Yes, that's a typo - it should be CRYPTO_ALGAPI

> However, I do not find a
> companion for CRYPTO_SHA224.  Is there a patch scheduled somewhere
> that adds this option?

No, I think that option is just incorrect and should be removed.

> 
> I detected your commit in today's Linux next tree by running
> ./scripts/checkkconfigsymbols.py.  Git commit 92503ee4ada1
> ("checkkconfigsymbols.py: make it Git aware") added the functionality
> to check Git commits and diff commits for such undefined symbols.

Great, I'll use it in future. Thanks for the notification. 

> 
> Kind regards,
> Valentin

Herbert: should I send you a patch to address the issues above, or resubmit the series with the fixes incorporated?

Thanks
James --
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/