Re: [PATCH 1/1 linux-next] fanotify: fix a lock in fanotify_should_send_event()

[Andrew Morton]

On Fri, 20 Mar 2015 21:56:08 +0100 Fabian Frederick <fabf@xxxxxxxxx> wrote:

> ltp/fanotify02 was locked since commit 66ba93c0d7fe
> ("fanotify: don't set FAN_ONDIR implicitly on a marks ignored mask")

What does "ltp/fanotify02 was locked" mean?  That this particular test
failed to exit, or...?

> --- a/fs/notify/fanotify/fanotify.c
> +++ b/fs/notify/fanotify/fanotify.c
> @@ -140,8 +140,8 @@ static bool fanotify_should_send_event(struct fsnotify_mark *inode_mark,
>  	}
>  
>  	if (d_is_dir(path->dentry) &&
> -	    !(marks_mask & FS_ISDIR & ~marks_ignored_mask))
> -		return false;
> +	    (marks_mask & FS_ISDIR & ~marks_ignored_mask))
> +		return true;

Should that be (marks_mask & FS_ISDIR & marks_ignored_mask)?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/