Re: [PATCH 1/1 linux-next] fanotify: fix a lock in fanotify_should_send_event()

[Fabian Frederick]

> On 20 March 2015 at 22:09 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
>
> On Fri, 20 Mar 2015 21:56:08 +0100 Fabian Frederick <fabf@xxxxxxxxx> wrote:
>
> > ltp/fanotify02 was locked since commit 66ba93c0d7fe
> > ("fanotify: don't set FAN_ONDIR implicitly on a marks ignored mask")
>
> What does "ltp/fanotify02 was locked" mean? That this particular test
> failed to exit, or...?
Hi Andrew,

 ÂIt failed to exit, exactly . No information displayed...
Problem appeared in 4.0-rc1.

Regards,
Fabian

>
> > --- a/fs/notify/fanotify/fanotify.c
> > +++ b/fs/notify/fanotify/fanotify.c
> > @@ -140,8 +140,8 @@ static bool fanotify_should_send_event(struct
> > fsnotify_mark *inode_mark,
> >Â Â Â}
> >Â
> >Â Â Âif (d_is_dir(path->dentry) &&
> > -Â Â Â Â!(marks_mask & FS_ISDIR & ~marks_ignored_mask))
> > -Â Â Â Â Â Âreturn false;
> > +Â Â Â Â(marks_mask & FS_ISDIR & ~marks_ignored_mask))
> > +Â Â Â Â Â Âreturn true;
>
> Should that be (marks_mask & FS_ISDIR & marks_ignored_mask)?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/