[PATCH 1/1] ceph: properly release page upon error

From: Taesoo Kim
Date: Fri Mar 20 2015 - 17:37:14 EST


When ceph_update_writeable_page fails (including -EAGAIN), it
unlocks (w/ unlock_page) the page but does not 'release'
(w/ page_cache_release) properly.

Upon error, properly set *pagep to NULL, indicating an error.

Signed-off-by: Taesoo Kim <tsgatesv@xxxxxxxxx>
---
fs/ceph/addr.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
index fd5599d..89091e3 100644
--- a/fs/ceph/addr.c
+++ b/fs/ceph/addr.c
@@ -1146,6 +1146,10 @@ static int ceph_write_begin(struct file *file, struct address_space *mapping,
inode, page, (int)pos, (int)len);

r = ceph_update_writeable_page(file, pos, len, page);
+ if (r) {
+ page_cache_release(page);
+ *pagep = NULL;
+ }
} while (r == -EAGAIN);

return r;
--
2.3.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/