Re: [PATCH v8 tip 3/9] tracing: attach BPF programs to kprobes

[Alexei Starovoitov]

On 3/20/15 2:09 PM, Steven Rostedt wrote:
> > +/**
> > + * trace_call_bpf - invoke BPF program
> > + * @prog - BPF program
> > + * @ctx - opaque context pointer
> > + *
> > + * kprobe handlers execute BPF programs via this helper.
> > + * Can be used from static tracepoints in the future.
>
> Should also state what the expected return values are. What does a
> return of "1" mean?

In earlier versions of this set I had detailed description of return
values from bpf program, somehow it got lost after all the revisions.
Will re-add.


> You are no longer in the net/ world. The rest of the Linux coding style
> is:
>
> 	/*
> 	 * multi line comments
> 	 */
>
> Only DaveM gets away with that format ;-)

:)
since bpf was born in the net/ world all comments are in that style.
When it moved into kernel/bpf/ we've decided to keep net/ style in there
as well, but for this file I don't mind using !net style ;)

> Reviewed-by: Steven Rostedt <rostedt@xxxxxxxxxxx>

Thanks a lot. Will respin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/