Re: [PATCH V2 1/1] X86: hyperv: Enable MSR based APIC access

[Ingo Molnar]

* K. Y. Srinivasan <kys@xxxxxxxxxxxxx> wrote:

> If the hypervisor supports MSR based access to the APIC registers
> (EOI, TPR and ICR), implement the MSR based access.
> 
> Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> ---
>  Changes from V1: Addressed comments from Ingo Molnar <mingo.kernel.org@xxxxxxxxx>

You didn't address my primary feedback:

> > So since we are trying to explain things, wouldn't this comment be 
> > more informative if it explained why we are trying to use the 
> > x2APIC facilities of Hyper-V?
> >
> > I.e. what are the benefits of using the x2apic API towards the 
> > hypervisor?

please explain the purpose, context and benefits, not just what the 
patch does - even if the comment from your first patch is now gone.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/