RE: [PATCH] staging: comedi: make comedi_internal.h self-reliant

[Hartley Sweeten]

On Friday, March 27, 2015 8:58 AM, Ian Abbott wrote,
> Add `#include`s and declare incomplete types to "comedi_internal.h" so
> that .c files still compile when it is the first file included.
>
> Signed-off-by: Ian Abbott <abbotti@xxxxxxxxx>
> ---
>  drivers/staging/comedi/comedi_internal.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/drivers/staging/comedi/comedi_internal.h b/drivers/staging/comedi/comedi_internal.h
> index d57817c..3b91853 100644
> --- a/drivers/staging/comedi/comedi_internal.h
> +++ b/drivers/staging/comedi/comedi_internal.h
> @@ -1,11 +1,21 @@
>  #ifndef _COMEDI_INTERNAL_H
>  #define _COMEDI_INTERNAL_H
>  
> +#include <linux/compiler.h>
>  #include <linux/types.h>
>  
>  /*
>   * various internal comedi stuff
>   */
> +
> +struct comedi_buf_map;
> +struct comedi_devconfig;
> +struct comedi_device;
> +struct comedi_insn;
> +struct comedi_rangeinfo;
> +struct comedi_subdevice;
> +struct device;
> +
>  int do_rangeinfo_ioctl(struct comedi_device *dev,
>  		       struct comedi_rangeinfo __user *arg);
>  struct comedi_device *comedi_alloc_board_minor(struct device *hardware_device);

Seems sane. Just to be clear, the build isn't currently broken.
This just insures that it doesn't break... :-)

Reviewed-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/