Re: [RFC 0/2] perf scripting cleanups
From: Arnaldo Carvalho de Melo
Date: Thu Apr 02 2015 - 10:15:53 EST
Em Thu, Apr 02, 2015 at 12:16:40PM +0300, Adrian Hunter escreveu:
> On 01/04/15 19:36, Arnaldo Carvalho de Melo wrote:
> > Hi David, Jiri,
> > Please take a look if it is ok for you guys
> > Adrian, there is another thing:
> > db_export__sample(&tables->dbe, event, sample, evsel, al->thread, al);
> > In tools/perf/util/scripting-engines/trace-event-python.c has this redundancy
> > as well, see the (al->thread, al), I'll probably remove that extra thread parm
> Yes please remove it too.
> > there if you don't have any other subtle use for that...
Ok, adding it as below, with your Acked-by, there is the one at the
bottom too, i.s. struct export_sample doesn't need a ->thread field,
same reason, if you are ok with that too, will add your Acked-by.