Re: [RFC 0/2] perf scripting cleanups

[Adrian Hunter]

On 01/04/15 19:36, Arnaldo Carvalho de Melo wrote:
> Hi David, Jiri,
> 
> 	Please take a look if it is ok for you guys
> 
> Adrian, there is another thing:
> 
>   db_export__sample(&tables->dbe, event, sample, evsel, al->thread, al);
> 
> In tools/perf/util/scripting-engines/trace-event-python.c has this redundancy
> as well, see the (al->thread, al), I'll probably remove that extra thread parm

Yes please remove it too.

> there if you don't have any other subtle use for that...

Nope

> 
> - Arnaldo
> 
> Arnaldo Carvalho de Melo (2):
>   perf script: No need to lookup thread twice
>   perf scripting: No need to pass thread twice to the scripting
>     callbacks
> 
>  tools/perf/builtin-script.c                            | 14 +++-----------
>  tools/perf/util/scripting-engines/trace-event-perl.c   |  5 ++---
>  tools/perf/util/scripting-engines/trace-event-python.c | 13 +++++--------
>  tools/perf/util/trace-event-scripting.c                |  1 -
>  tools/perf/util/trace-event.h                          |  3 +--
>  5 files changed, 11 insertions(+), 25 deletions(-)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/