Re: [PATCH v3 5/7] tracing: Add 'hist' event trigger command

[Paul Bolle]

On Mon, 2015-04-06 at 11:50 -0400, Steven Rostedt wrote:
> On Sat, 04 Apr 2015 17:14:56 +0200
> Paul Bolle <pebolle@xxxxxxxxxx> wrote: 
> > > --- a/kernel/trace/Makefile
> > > +++ b/kernel/trace/Makefile
> > 
> > > +obj-$(CONFIG_HIST_TRIGGERS) += trace_events_hist.o
> > 
> > To make sure I'm parsing this Makefile correctly: trace_events_hist.o
> > will never be part of a module, right?
> 
> You don't need to be part of a module to need module.h. You may just
> need module info.

I understand.

But the main reason I added that remark was that recently I ran into a
few patches where I made annoying mistakes in parsing changes to
Makefiles. Doing so I wasted my own and other peoples time. So I decided
to be rather verbose when Makefiles are involved. Just so that people
can:
- mock me for not getting basic stuff right;
- stop paying attention to the rest of my remarks, because chances are I
didn't understand the patch in question correctly.

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/