Re: [PATCH v3 5/7] tracing: Add 'hist' event trigger command

From: Steven Rostedt
Date: Mon Apr 06 2015 - 12:25:58 EST

On Mon, 06 Apr 2015 18:19:19 +0200
Paul Bolle <pebolle@xxxxxxxxxx> wrote:

> But the main reason I added that remark was that recently I ran into a
> few patches where I made annoying mistakes in parsing changes to
> Makefiles. Doing so I wasted my own and other peoples time. So I decided
> to be rather verbose when Makefiles are involved. Just so that people
> can:
> - mock me for not getting basic stuff right;

I hope you don't think I was mocking you. I wasn't.

> - stop paying attention to the rest of my remarks, because chances are I
> didn't understand the patch in question correctly.

I wouldn't put your comments up as useless. I could imagine people
going through and cleaning up header includes, as long as not much
impact is made.

The only issue I can think of that including an unneeded header file
does is to make the compile slightly longer. It's not a major need to
do, but it may be done.

-- Steve

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at