Re: [PATCH 2/2] ide: replace GFP_ATOMIC by GFP_KERNEL

[Dan Carpenter]

Sorry, my last email was bad.

Splitting patches into logical parts is a bit tricky.  Let me try
explain better.

Every patch should sort of make sense on its own.  In the original code
it's using GFP_ATOMIC but that's because the original API was bad and
we had no choice.  In the 1/1 patch we're using GFP_ATOMIC explicitly
by choice and it's wrong.  In patch 2/2 we fix this problem but we
shouldn't introduce bad code even if we fix it in later patches.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/