Re: [PATCH v2 3/8] kernel/params.c: generalize bool_enable_only

[Tejun Heo]

Hello,

On Wed, Apr 22, 2015 at 02:55:06PM -0700, Luis R. Rodriguez wrote:
> +int param_set_bool_enable_only(const char *val, const struct kernel_param *kp)
> +{
> +	int err = 0;
> +	bool new_value;
> +	bool orig_value = *(bool *)kp->arg;
> +	struct kernel_param dummy_kp = *kp;
> +
> +	dummy_kp.arg = &new_value;
> +
> +	err = param_set_bool(val, &dummy_kp);
> +	if (err)
> +		return err;
> +
> +	/* Don't let them unset it once it's set! */
> +	if (!new_value && orig_value)
> +		return -EROFS;

I know that this was moved from another place but as we're making it
generic now I'm a bit curious about -EROFS.  Wouldn't -EINVAL be a
more conventional choice here?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/