Re: [PATCH] kvm: x86: fix kvmclock update protocol

From: Radim KrÄmÃÅ
Date: Thu Apr 23 2015 - 11:24:18 EST


2015-04-23 13:46+0200, Paolo Bonzini:
> From: Radim KrÄmÃÅ <rkrcmar@xxxxxxxxxx>
>
> The kvmclock spec says that the host will increment a version field to
> an odd number, then update stuff, then increment it to an even number.
> The host is buggy and doesn't do this, and the result is observable
> when one vcpu reads another vcpu's kvmclock data.
>
> There's no good way for a guest kernel to keep its vdso from reading
> a different vcpu's kvmclock data, but we don't need to care about
> changing VCPUs as long as we read a consistent data from kvmclock.
> (VCPU can change outside of this loop too, so it doesn't matter if we
> return a value not fit for this VCPU.)
>
> Based on a patch by Radim KrÄmÃÅ.
>
> Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> ---

Nice,

Reviewed-by: Radim KrÄmÃÅ <rkrcmar@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/