Re: [PATCH 2/3] platform: x86: dell-rbtn: Export notifier for other kernel modules

[Pali RohÃr]

On Tuesday 25 November 2014 14:39:37 Darren Hart wrote:
> On Sun, Nov 23, 2014 at 04:09:20PM +0100, Pali RohÃr wrote:
> > This patch exports notifier functions so other modules can receive HW switch
> > events. By default when some module register notifier, dell-rbtn driver
> 
> The commit message needs to describe the problem being addressed as well. Why is
> this necessary?
> 

Needed for next patch (3/3). All 3 patches are one series, so I do no
think that everything is needed to describe...

> > automatically remove rfkill interfaces from system (it is expected that other
> > module will use events for other rfkill interface). This behaviour can be
> > changed with new module parameter "auto_remove_rfkill".
> 
> We try to avoid using such parameters to define behavior when possible.
> 
> Why is it justified to use auto_remove_rfkill here? When is it needed? As
> opposed to doing something that works based on the detected hardware? (It could
> be this is the right thing, but we have to justify it).
> 

Just for future if something goes wrong and new Dell BIOS stopped
working. So users would be able to "hotfix" unexpected problems.

As Alex wrote, some machine has already BIOS bug...

-- 
Pali RohÃr
pali.rohar@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/