Re: [PATCH 2/2] i2c / ACPI: Assign IRQ for devices that have GpioInt automatically

From: Wolfram Sang
Date: Wed Apr 29 2015 - 05:56:23 EST



> - if (!client->irq && dev->of_node) {
> - int irq = of_irq_get(dev->of_node, 0);
> + if (client->irq <= 0) {
> + int irq = -ENOENT;

Why the move from !client->irq to <= 0? If I didn't miss something,
interrupt numbers are still a sleeping dog with all the unsigned vs
signed fuzz. If this change is needed, this needs proper description and
ideally a seperate patch.

Attachment: signature.asc
Description: Digital signature