Re: [PATCH 2/2] i2c / ACPI: Assign IRQ for devices that have GpioInt automatically

[Mika Westerberg]

On Wed, Apr 29, 2015 at 11:56:06AM +0200, Wolfram Sang wrote:
> 
> > -	if (!client->irq && dev->of_node) {
> > -		int irq = of_irq_get(dev->of_node, 0);
> > +	if (client->irq <= 0) {
> > +		int irq = -ENOENT;
> 
> Why the move from !client->irq to <= 0? If I didn't miss something,
> interrupt numbers are still a sleeping dog with all the unsigned vs
> signed fuzz. If this change is needed, this needs proper description and
> ideally a seperate patch.

It is there because ACPI parts of I2C client enumeration code
initializes client->irq with -1. Alternatively we can change that code
to use 0 for missing IRQ.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/