Re: [PATCH v2] tracing: make ftrace_print_array_seq compute buf_len

[Alex BennÃe]

Steven Rostedt <rostedt@xxxxxxxxxxx> writes:

> On Wed, 29 Apr 2015 16:18:46 +0100
> Alex BennÃe <alex.bennee@xxxxxxxxxx> wrote:
>
>> The only caller to this function (__print_array) was getting it wrong by
>> passing the array length instead of buffer length. As the element size
>> was already being passed for other reasons it seems reasonable to push
>> the calculation of buffer length into the function.
>> 
>> Signed-off-by: Alex BennÃe <alex.bennee@xxxxxxxxxx>
>
> Thanks, I'll add a stable tag to this too, and get it out soon.

I take it you'll pick up Dave's reviewed-by?

As for CC'ing stable I wouldn't worry too much as nothing in the kernel
uses __print_array yet (unless you count the example). But it is a
fairly trivial patch so if you as the maintainer is happy I'm happy ;-)

>
> -- Steve
>
>> 
>> ---
>> v2:
>>   - more explicit commit message
>>   - rename len -> count to reduce ambiguity
>> ---
>>  include/linux/ftrace_event.h | 2 +-
>>  kernel/trace/trace_output.c  | 3 ++-
>>  2 files changed, 3 insertions(+), 2 deletions(-)
>> 

-- 
Alex BennÃe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/