Re: [PATCH v3 4/6] crypto: drbg - add async seeding operation

[Herbert Xu]

On Tue, Apr 28, 2015 at 05:00:03AM +0200, Stephan Mueller wrote:
>
> @@ -1081,6 +1115,11 @@ static int drbg_seed(struct drbg_state *drbg, struct drbg_string *pers,
>  		return -EINVAL;
>  	}
>  
> +	/* cancel any previously invoked seeding */
> +	mutex_unlock(&drbg->drbg_mutex);
> +	drbg_async_work_cancel(&drbg->seed_work);
> +	mutex_lock(&drbg->drbg_mutex);

This seems dangerous and unnecessary.  Releasing and reacquiring
the locks may invalidate previous checks.  Even if it doesn't
matter today if somebody modifies the callers later on this could
explode.

You can easily remove this by making get_blocking_random_bytes_cb
idempotent, i.e., do nothing if the work is already queued, which
is what it would do anyway if you simply move the INIT_WORK out of
it.

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/