Re: [PATCH 1/2] crypto: Constify (de)compression parameters

[Herbert Xu]

On Tue, Apr 28, 2015 at 03:36:30PM +0100, David Howells wrote:
> In testmgr, struct pcomp_testvec takes a non-const 'params' field, which is
> pointed to a const deflate_comp_params or deflate_decomp_params object.  With
> gcc-5 this incurs the following warnings:
> 
> In file included from ../crypto/testmgr.c:44:0:
> ../crypto/testmgr.h:28736:13: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-array-qualifiers]
>    .params = &deflate_comp_params,
>              ^
> ../crypto/testmgr.h:28748:13: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-array-qualifiers]
>    .params = &deflate_comp_params,
>              ^
> ../crypto/testmgr.h:28776:13: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-array-qualifiers]
>    .params = &deflate_decomp_params,
>              ^
> ../crypto/testmgr.h:28800:13: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-array-qualifiers]
>    .params = &deflate_decomp_params,
>              ^
> 
> Fix this by making the parameters pointer const and constifying the things
> that use it.
> 
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>

Both patches applied.
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/