Re: [PATCH v2 10/21] staging: rtl8192e: replace memcpy() -> ether_addr_copy_unaligned()
From: Greg KH
Date: Sun May 03 2015 - 15:11:24 EST
On Mon, Apr 13, 2015 at 11:47:33PM +0200, Mateusz Kulikowski wrote:
> rtl8192e driver uses memcpy() to copy hw addresses in several places.
> checkpatch.pl suggests to use ether_addr_copy(), but most of
> addresses in driver may be unaligned.
> This patch replaces all memcpy occurences with single macro therby
> silencing checkpatch.pl (single complaints in macro remains).
>
> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@xxxxxxxxx>
> ---
> drivers/staging/rtl8192e/rtl819x_BAProc.c | 12 ++---
> drivers/staging/rtl8192e/rtllib.h | 3 ++
> drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 18 +++----
> drivers/staging/rtl8192e/rtllib_rx.c | 74 +++++++++++++++++-----------
> drivers/staging/rtl8192e/rtllib_softmac.c | 67 +++++++++++++------------
> drivers/staging/rtl8192e/rtllib_softmac_wx.c | 5 +-
> drivers/staging/rtl8192e/rtllib_tx.c | 24 ++++-----
> 7 files changed, 113 insertions(+), 90 deletions(-)
I've stopped applying here, no need to resend the first 9 of these
patches for your next round.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/