Re: [PATCH 3/7] x86/intel_rdt: Support cache bit mask for Intel CAT
From: Peter Zijlstra
Date: Wed May 06 2015 - 04:09:41 EST
On Mon, May 04, 2015 at 10:30:15AM -0700, Vikas Shivappa wrote:
> On Sat, 2 May 2015, Peter Zijlstra wrote:
>
> >
> >There's CAT in your subject, make up your minds already on what you want
> >to call this stuff.
>
> We dont have control over the names.It is clear from the patch 0/7 where its
If I read 0/n its _after_ I've read all the other patches. The thing is,
0/n should not contain anything persistent. Patches should stand on
their own.
> explained that RDT is the umbrella term and CAT is a part of it and this
> patch series is only for CAT ... It also mentions what exact section of the
> Intel manual this refers to. Is there still some lack of clarification here
> ?
But we're not implementing an umbrella right? We're implementing Cache
QoS Enforcement (CQE aka. CAT).
Why confuse things with calling it random other names?
>From what I understand the whole RDT thing is the umbrella term for
Cache QoS Monitoring and Enforcement together. CQM is implemented
elsewhere, this part is only implementing CQE.
So just call it that, calling it RDT is actively misleading, because it
explicitly does _NOT_ do the monitoring half of it.
> If its just your disliking the term thats already known.
I think its crazy to go CQE no CAT no RDT, but I could get over that in
time. But now it turns out you need _both_, and that's even more silly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/