Re: [PATCH v4 2/2] spi: omap2-mcspi: Add gpio_request and init CS

From: Michael Welling
Date: Fri May 08 2015 - 13:37:44 EST


On Fri, May 08, 2015 at 06:09:16PM +0100, Mark Brown wrote:
> On Thu, May 07, 2015 at 06:36:54PM -0500, Michael Welling wrote:
>
> > + if (gpio_is_valid(spi->cs_gpio)) {
> > + if (gpio_request(spi->cs_gpio, dev_name(&spi->dev)) == 0)
> > + gpio_direction_output(spi->cs_gpio,
> > + !(spi->mode & SPI_CS_HIGH));
> > + }
>
> I'm not seeing anything that frees this GPIO?

Ooops I forgot to add this to the cleanup function.

It appears that the transfer_one patch got applied so how should I
provide the new version of this patch?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/