RE: [x86/xsaves] 4d90fc49c73: WARNING: CPU: 3 PID: 168 at arch/x86/kernel/xsave.c:306 save_xstate_sig+0x3a7/0x3d0()

From: Yu, Fenghua
Date: Sat May 09 2015 - 11:23:22 EST



> Here is another warning bisected to the same commit.
>
> https://github.com/hansendc/linux.git github-mpx commit
> 4d90fc49c73730c09d7afd515f9c4e08d30229bd ("x86/xsaves: Define and use
> user_xstate_size for xstate size in signal context")
> [ 6.210858] WARNING: CPU: 3 PID: 168 at arch/x86/kernel/xsave.c:306
> save_xstate_sig+0x3a7/0x3d0()
> [ 6.210860] mismatched xstate sizes

The issue has been fixed in https://lkml.org/lkml/2015/5/8/737

The patch in this git tree missed the following part when ported
to this git tree.

diff --git a/arch/x86/kernel/i387.c b/arch/x86/kernel/i387.c
index 00918327..8a7b96b 100644
--- a/arch/x86/kernel/i387.c
+++ b/arch/x86/kernel/i387.c
@@ -166,6 +166,7 @@ static void init_thread_xstate(void)
setup_clear_cpu_cap(X86_FEATURE_XSAVE);
setup_clear_cpu_cap(X86_FEATURE_XSAVEOPT);
xstate_size = sizeof(struct i387_soft_struct);
+ user_xstate_size = xstate_size;
return;
}

@@ -173,6 +174,8 @@ static void init_thread_xstate(void)
xstate_size = sizeof(struct i387_fxsave_struct);
else
xstate_size = sizeof(struct i387_fsave_struct);
+
+ user_xstate_size = xstate_size;
}

/*

Thanks.

-Fenghua

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/