Re: [PATCH v2 1/3] gpio / ACPI: Add support for retrieving GpioInt resources from a device

From: Linus Walleij
Date: Mon May 11 2015 - 05:56:52 EST


On Wed, May 6, 2015 at 12:29 PM, Mika Westerberg
<mika.westerberg@xxxxxxxxxxxxxxx> wrote:

> ACPI specification knows two types of GPIOs: GpioIo and GpioInt. The latter
> is used to describe that a given device interrupt line is connected to a
> specific GPIO pin. Typical ACPI _CRS entry for such device looks like
> below:
>
> Name (_CRS, ResourceTemplate ()
> {
> I2cSerialBus (0x004A, ControllerInitiated, 0x00061A80,
> AddressingMode7Bit, "\\_SB.PCI0.I2C6",
> 0x00, ResourceConsumer)
> GpioIo (Exclusive, PullDefault, 0x0000, 0x0000,
> IoRestrictionOutputOnly, "\\_SB.GPO0",
> 0x00, ResourceConsumer)
> {
> 0x004B
> }
> GpioInt (Level, ActiveLow, Shared, PullDefault, 0x0000,
> "\\_SB.GPO0", 0x00, ResourceConsumer)
> {
> 0x004C
> }
> })
>
> Currently drivers need to request a GPIO corresponding to the right GpioInt
> and then translate that to Linux IRQ number. This adds unnecessary lines of
> boiler-plate code.
>
> We can ease this a bit by introducing acpi_dev_gpio_irq_get() analogous to
> of_irq_get(). This function translates given GpioInt resource under the
> device in question to the suitable Linux IRQ number.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/