Re: [PATCH v11 07/10] iommu/vt-d: enable kdump support in iommu module

From: Li, ZhenHua
Date: Tue May 12 2015 - 22:29:17 EST

+static u8 g_translation_pre_enabled;
Hi Zhenhua,

I haven't checked patch one by one, am going through the code flow.

About g_translation_pre_enabled, I don't think it's necessary to define
it as a global variable. Both its assignment and judgement are in
init_dmars(). In this situation a local variable translation_pre_enabled
in init_dmars() is enough.

You can assign value to it here:

if (iommu->pre_enabled_trans) {
translation_pre_enabled = 1;


Hi Baoquan,
This variable is only be used in this file, for it is defined as static.
Till now, I think both global and local variable are fine, got the same
But I believe global is better, because if other functions want to know whether translation is enabled, this global variable is a good choice.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at