Re: [PATCH v2 06/10] mfd: cros_ec: add proto v3 skeleton

[Javier Martinez Canillas]

Hello Lee,

Thanks a lot for your feedback.

On 05/13/2015 02:05 PM, Lee Jones wrote:
> On Sat, 09 May 2015, Javier Martinez Canillas wrote:
> 
>> From: Stephen Barber <smbarber@xxxxxxxxxxxx>
>> 
>> Add support in cros_ec.c to handle EC host command protocol v3.
>> For v3+, probe for maximum shared protocol version and max
>> request, response, and passthrough sizes. For now, this will
>> always fall back to v2, since there is no bus-specific code
>> for handling proto v3 packets.
>> 
>> Signed-off-by: Stephen Barber <smbarber@xxxxxxxxxxxx>
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx>
>> Reviewed-by: Gwendal Grignou <gwendal@xxxxxxxxxxxx>
>> Tested-by: Gwendal Grignou <gwendal@xxxxxxxxxxxx>
>> ---
>> 
>> Changes since v1:
>>  - Squash change https://chromium-review.googlesource.com/#/c/262870/ in
>>    the patch. Suggested by Gwendal Grignou
>>  - Add Reviewed-by and Tested-by tags from Gwendal Grignou
>> ---
>>  drivers/mfd/cros_ec.c                 | 354 ++++++++++++++++++++++++++++++----
>>  drivers/mfd/cros_ec_i2c.c             |   4 +
>>  drivers/mfd/cros_ec_spi.c             |   7 +-
>>  drivers/platform/chrome/cros_ec_lpc.c |   4 +
>>  include/linux/mfd/cros_ec.h           |  20 +-
>>  5 files changed, 344 insertions(+), 45 deletions(-)
> 
> This patch nearly triples the size of the driver, which I'm less than
> happy about.  This driver is starting to suffer from feature-creep
> when comparing against the original implementation.  I'd like to extract
> 'protocol drivers' out if possible.  Would this be better suited in
> drivers/platform?
> 

Agreed that this mfd driver is getting too complex. I'll see how I can
split the communication/transport logic into a separate driver under
platforms/chrome and only keep the mfd cells registration logic in
drivers/mfd/cros_ec.c

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/