[RFC v2 3/6] crypto: qat - address recursive dependency when fw signing is enabled

From: Luis R. Rodriguez
Date: Wed May 13 2015 - 14:32:49 EST

From: "Luis R. Rodriguez" <mcgrof@xxxxxxxx>

We're going to add firmware module signing support, but when we do
this we end up with the following recursive dependency. Fix this by
just depending on FW_LOADER, which is typically always enabled
anyway. We do this as a compromise for now as FW_LOADER is only
selectable when EXPERT is enabled and the recursive dependency issue
below is actually real and valid, its proper fix however requires
a bit of work.

This technically means this change is likely welcomed for other
parts of the kernel but this is really only needed for now here.

mcgrof@ergon ~/linux-next (git::master)$ make allnoconfig
scripts/kconfig/conf --allnoconfig Kconfig
crypto/Kconfig:15:error: recursive dependency detected!
crypto/Kconfig:15: symbol CRYPTO is selected by SYSDATA_SIG
init/Kconfig:1880: symbol SYSDATA_SIG is selected by FIRMWARE_SIG
drivers/base/Kconfig:88: symbol FIRMWARE_SIG depends on FW_LOADER
drivers/base/Kconfig:80: symbol FW_LOADER is selected by CRYPTO_DEV_QAT
drivers/crypto/qat/Kconfig:1: symbol CRYPTO_DEV_QAT is selected by CRYPTO_DEV_QAT_DH895xCC
drivers/crypto/qat/Kconfig:13: symbol CRYPTO_DEV_QAT_DH895xCC depends on CRYPTO

Cc: Paul Bolle <pebolle@xxxxxxxxxx>
Cc: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
Cc: David Howells <dhowells@xxxxxxxxxx>
Cc: Ming Lei <ming.lei@xxxxxxxxxxxxx>
Cc: Kyle McMartin <kyle@xxxxxxxxxx>
Cc: Bruce Allan <bruce.w.allan@xxxxxxxxx>
Cc: Tadeusz Struk <tadeusz.struk@xxxxxxxxx>
Cc: John Griffin <john.griffin@xxxxxxxxx>
Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxx>
drivers/crypto/qat/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/qat/Kconfig b/drivers/crypto/qat/Kconfig
index 49bede2..9bea338 100644
--- a/drivers/crypto/qat/Kconfig
+++ b/drivers/crypto/qat/Kconfig
@@ -8,7 +8,7 @@ config CRYPTO_DEV_QAT
select CRYPTO_SHA1
select CRYPTO_SHA256
select CRYPTO_SHA512
- select FW_LOADER
+ depends on FW_LOADER

tristate "Support for Intel(R) DH895xCC"

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/