Re: [RFC v2 3/6] crypto: qat - address recursive dependency when fw signing is enabled

From: Herbert Xu
Date: Wed May 13 2015 - 23:04:48 EST

On Wed, May 13, 2015 at 11:23:53AM -0700, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcgrof@xxxxxxxx>
> We're going to add firmware module signing support, but when we do
> this we end up with the following recursive dependency. Fix this by
> just depending on FW_LOADER, which is typically always enabled
> anyway. We do this as a compromise for now as FW_LOADER is only
> selectable when EXPERT is enabled and the recursive dependency issue
> below is actually real and valid, its proper fix however requires
> a bit of work.
> This technically means this change is likely welcomed for other
> parts of the kernel but this is really only needed for now here.

Nack. Either fix kbuild or make every user of FW_LOADER use
a dependency. Singling out a single crypto device makes zero

Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page:
PGP Key:
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at