Re: [RFC v2 3/6] crypto: qat - address recursive dependency when fw signing is enabled

[Luis R. Rodriguez]

On Thu, May 14, 2015 at 11:04:15AM +0800, Herbert Xu wrote:
> On Wed, May 13, 2015 at 11:23:53AM -0700, Luis R. Rodriguez wrote:
> > From: "Luis R. Rodriguez" <mcgrof@xxxxxxxx>
> > 
> > We're going to add firmware module signing support, but when we do
> > this we end up with the following recursive dependency. Fix this by
> > just depending on FW_LOADER, which is typically always enabled
> > anyway. We do this as a compromise for now as FW_LOADER is only
> > selectable when EXPERT is enabled and the recursive dependency issue
> > below is actually real and valid, its proper fix however requires
> > a bit of work.
> > 
> > This technically means this change is likely welcomed for other
> > parts of the kernel but this is really only needed for now here.
> 
> Nack.  Either fix kbuild or make every user of FW_LOADER use
> a dependency.  Singling out a single crypto device makes zero
> sense.

I think that's fair... Paul, did you get to look into the
recursive issue some more by any chance? Any preference for
what path to take here?

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/