Re: [alsa-devel] [RFC PATCH 00/14] ASoC: qcom: add support to apq8016 audio

[Srinivas Kandagatla]

On 12/05/15 18:04, Lars-Peter Clausen wrote:
> > Its not clear from code, why should we enter to legacy naming if the dais
> > count == 1 even-though the dai_drv has has valid name and id information.
> >
> > Mark/Lars,
> >
> > I can workaround this by using dai->driver->id in the driver, But do you
> > think that dai name and id should be assigned from dai drv if present?
>
> I think it should be OK to extend that if condition to
>
> if (count == 1 && dai_drv[0].id == 0 && legacy_dai_naming) ...
>
> It doesn't look like any of the systems for which we currently take the
> legacy path do set id to non 0. And the less new systems following
> legacy naming scheme the better.
Thanks Lars, will send out an RFC patch and see what other people thing.

--srini
> - Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/