Re: [PATCH] ASoC: codecs-ac97: make selectable in config

From: Lars-Peter Clausen
Date: Thu May 14 2015 - 15:24:25 EST

On 05/14/2015 09:10 PM, Mark Brown wrote:
On Thu, May 14, 2015 at 08:46:09PM +0200, Lars-Peter Clausen wrote:
On 05/14/2015 07:53 PM, Mark Brown wrote:

select doesn't respect dependencies, it'll just force on the selected

The patch works fine, neither SND_SOC_AC97_BUS nor the symbols selected by
SND_SOC_AC97_BUS have any dependencies.

Does the select from SND_SOC_AC97_BUS actually happen if it is selected
by SND_SOC_ALL_CODECS? That's the issue, if it works now it's a
relatively recent thing.

I'm not sure I fully understand what you mean.

The Kconfig entry for the CODEC has no 'depends on'. It does a 'select SND_SOC_AC97_BUS', which means all built time dependencies are pulled in this way. So if SND_SOC_ALL_CODECS selects the CODEC unconditionally that should work fine, since no dependencies are bypassed.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at