Re: [PATCH] ASoC: codecs-ac97: make selectable in config

From: Mark Brown
Date: Thu May 14 2015 - 15:29:11 EST

On Thu, May 14, 2015 at 09:24:15PM +0200, Lars-Peter Clausen wrote:
> On 05/14/2015 09:10 PM, Mark Brown wrote:

> >Does the select from SND_SOC_AC97_BUS actually happen if it is selected
> >by SND_SOC_ALL_CODECS? That's the issue, if it works now it's a
> >relatively recent thing.

> I'm not sure I fully understand what you mean.

> The Kconfig entry for the CODEC has no 'depends on'. It does a 'select
> SND_SOC_AC97_BUS', which means all built time dependencies are pulled in
> this way. So if SND_SOC_ALL_CODECS selects the CODEC unconditionally that
> should work fine, since no dependencies are bypassed.

No, it's not just dependencies but also selects that get ignored (or
used to anyway like I say) - a select just forces the symbol on.

Attachment: signature.asc
Description: Digital signature