Re: [PATCH] ASoC: codecs-ac97: make selectable in config

[Lars-Peter Clausen]

On 05/14/2015 09:28 PM, Mark Brown wrote:
> On Thu, May 14, 2015 at 09:24:15PM +0200, Lars-Peter Clausen wrote:
> > On 05/14/2015 09:10 PM, Mark Brown wrote:
>
> > > Does the select from SND_SOC_AC97_BUS actually happen if it is selected
> > > by SND_SOC_ALL_CODECS?  That's the issue, if it works now it's a
> > > relatively recent thing.
>
> > I'm not sure I fully understand what you mean.
>
> > The Kconfig entry for the CODEC has no 'depends on'. It does a 'select
> > SND_SOC_AC97_BUS', which means all built time dependencies are pulled in
> > this way. So if SND_SOC_ALL_CODECS selects the CODEC unconditionally that
> > should work fine, since no dependencies are bypassed.
>
> No, it's not just dependencies but also selects that get ignored (or
> used to anyway like I say) - a select just forces the symbol on.

select forces a symbol on regardless of whether its dependencies are met or 
not. But for any symbol that is on, no matter whether it was manually 
selected or selected by a 'select' from another symbol, any symbols selected 
by that symbol will be turned on. It's been that way as long as I can remember.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/