Re: [RFC PATCH v3 32/37] perf bpf: Parse probe points of eBPF programs during preparation

[Jiri Olsa]

On Sun, May 17, 2015 at 10:56:57AM +0000, Wang Nan wrote:

SNIP

> +	if (pev)
> +		clear_perf_probe_event(pev);
> +	return err;
> +}
> +
>  int bpf_prepare_load(const char *filename)
>  {
>  	struct bpf_object *obj;
> @@ -81,6 +150,8 @@ int bpf_prepare_load(const char *filename)
>  			return -EINVAL;
>  		}
>  		pr_debug("bpf: add program '%s'\n", title);
> +
> +		bpf_do_config(params.nr_progs - 1, title);

shouldn't you check&pass return value of bpf_do_config ?

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/