Re: [PATCH 1/1] drivers: staging: rtl8192u: ieee80211: ieee80211_softmac.c: auth parse error code byte order fix

[Paul Gortmaker]

On 15-05-23 10:53 PM, tolga ceylan wrote:
> On 05/12/2015 08:55 PM, Tolga Ceylan wrote:
>> Error code returned from auth_parse() should in cpu byte order.
>>
>> Signed-off-by: Tolga Ceylan <tolga.ceylan@xxxxxxxxx>
>> ---
>>   drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
>> index d2e8b12..0cf0e89 100644
>> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
>> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
>> @@ -1558,7 +1558,7 @@ static inline u16 auth_parse(struct sk_buff *skb, u8 **challenge, int *chlen)
>>   		}
>>   	}
>>
>> -	return cpu_to_le16(a->status);
>> +	return le16_to_cpu(a->status);
>>
>>   }
>>
>>
> 
> I haven't gotten a response for this patch. Just checking back.

In the future, you can help speed up the review process by helping
the reviewer/maintainer.  How?  In your commit log.  Describe the 
end user symptoms and how the problem was found, why it happens
and what is the best fix for the problem (assuming it isn't trivially
obvious).  So, instead of just translating the C change into words
for a commit log like you had above, you could have instead had...

	When trying to use an RL8192 with auth mode foo and module
	parameter blah blah, the driver fails to connect, only showing
	blah blah in the logs.

	This happens because auth_parse blah blah and returns blah
	which is incorrectly interpreted by foo_bar() since it is in
	the wrong endian as blah is in native byte order and ...

	We fix it by noting the error value should be ... since ...


Also, minor nit ; if you are going to put a path fragment in the subject,
then don't replace all the / with ": " --- i.e. use
	
 [PATCH] staging: rtl8192u/ieee80211/ieee80211_softmac.c: auth parse error code byte order fix

or 

 [PATCH] staging/rtl8192u: ieee80211_softmac.c - auth parse error code byte order fix

Paul.
--

> 
> Regards,
> Tolga Ceylan
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/