Re: [PATCH] livepatch: match function return value type with prototype

[Minfei Huang]

On Tue, May 26, 2015 at 10:44 AM, Li Bin <huawei.libin@xxxxxxxxxx> wrote:
> The klp_is_module return type should be boolean.
>
> Signed-off-by: Li Bin <huawei.libin@xxxxxxxxxx>
> ---
>  kernel/livepatch/core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
> index 284e269..30e9339 100644
> --- a/kernel/livepatch/core.c
> +++ b/kernel/livepatch/core.c
> @@ -78,7 +78,7 @@ static struct klp_ops *klp_find_ops(unsigned long old_addr)
>
>  static bool klp_is_module(struct klp_object *obj)
>  {
> -       return obj->name;
> +       return !!obj->name;
>  }

Hi, Bin.

Does compile blame the prototype before you convert it? If not, I think
we do not need to fix it, since there are a lot of places in kernel where
we return point value as boolean.

Thanks
Minfei

>
>  static bool klp_is_object_loaded(struct klp_object *obj)
> --
> 1.7.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe live-patching" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/