Re: [PATCH v2] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

From: Gaston Gonzalez
Date: Tue Jun 02 2015 - 10:36:54 EST


On Tue, Jun 02, 2015 at 11:09:41AM +0530, Sudip Mukherjee wrote:
> On Mon, Jun 01, 2015 at 09:43:31PM -0300, Gaston Gonzalez wrote:
> > Fix the following sparse warnings:
> >
> > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> > index d2e8b12..d0a6a59 100644
> > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> > @@ -660,8 +660,10 @@ inline struct sk_buff *ieee80211_authentication_req(struct ieee80211_network *be
> > auth = (struct ieee80211_authentication *)
> > skb_put(skb, sizeof(struct ieee80211_authentication));
> >
> > - auth->header.frame_ctl = IEEE80211_STYPE_AUTH;
> > - if (challengelen) auth->header.frame_ctl |= IEEE80211_FCTL_WEP;
> > + if (challengelen)
> > + auth->header.frame_ctl = cpu_to_le16(IEEE80211_STYPE_AUTH | IEEE80211_FCTL_WEP);
> it is introducing new checkpatch warning of "line over 80 characters".
>
> regards
> sudip
Yes, you are right. I'll send a v3 including with that fixed.

Thanks for the feedback,

Gaston
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/